alexey.zholtikov/upm
1
0
Fork 0
mirror of https://github.com/eclipse/upm.git synced 2025-07-02 09:51:14 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

I2C: Removing multiple address calls

Browse Source 
~20 UPM modules have multiple I2C calls in them. As per MRAA API
the I2C address is set in the MRAA I2C context and used from there
for all I2C transactions. Setting the I2C address alone does not
actually result in an I2C transaction. This makes multiple set
address calls pointless. This commit removes these superflous set
address calls from the UPM modules. Setting the address once per
context per device should be enough, unless there are multiple
addresses or multiple devices with different addresses.

Signed-off-by: Abhishek Malik <abhishek.malik@intel.com>
This commit is contained in:
Abhishek Malik
2017-05-31 11:47:23 -07:00
parent da18bac925
commit 50bb4ae1be
22 changed files with 2 additions and 161 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/t6713/t6713.cxx
View File

@ -98,12 +98,6 @@ uint16_t T6713::getSensorData (MODBUS_COMMANDS cmd)
//printf("\nI2C mode set\n");
data = 0;
runCommand(cmd);
mraa::Result ret = i2c.address(T6713_ADDR);
if (ret != mraa::SUCCESS)
{
UPM_THROW ("I2C error setting slave address");
// TODO: need to handle this
}
RESPONSE response;
if((readBytes = i2c.read((uint8_t*)(&response), sizeof(RESPONSE) ) != sizeof(RESPONSE)))
{
@ -152,11 +146,6 @@ mraa::Result T6713::runCommand(MODBUS_COMMANDS cmd)
cmdPacket.register_address_lsb = (T6713_REG_STATUS & 0xff);
cmdPacket.input_registers_to_read_msb = 0;
cmdPacket.input_registers_to_read_lsb = 1;
ret = i2c.address(T6713_ADDR);
if (ret != mraa::SUCCESS)
{
UPM_THROW ("I2C error setting slave address");
}
if((ret = i2c.write((const uint8_t*) (&cmdPacket), sizeof(COMMAND))) != mraa::SUCCESS)
{
@ -180,13 +169,6 @@ mraa::Result T6713::runCommand(MODBUS_COMMANDS cmd)
cmdPacket.input_registers_to_read_msb = 0;
cmdPacket.input_registers_to_read_lsb = 1;
ret = i2c.address(T6713_ADDR);
if (ret != mraa::SUCCESS)
{
UPM_THROW ("I2C error setting slave address");
//need to handle this
}
if((ret = i2c.write((const uint8_t*) (&cmdPacket), sizeof(COMMAND))) != mraa::SUCCESS)
{
@ -205,12 +187,6 @@ STATUS T6713::getStatus()
uint16_t responseStatus = 0, readBytes = 0;
RESPONSE response;
runCommand(T6713_COMMAND_STATUS);
mraa::Result ret = i2c.address(T6713_ADDR);
if (ret != mraa::SUCCESS)
{
UPM_THROW ("I2C error setting slave address");
//need to handle tnis
}
if((readBytes = i2c.read((uint8_t*) (&response), sizeof(RESPONSE)) != sizeof(RESPONSE)))
{
UPM_THROW("I2C read failed");