alexey.zholtikov/upm
1
0
Fork 0
mirror of https://github.com/eclipse/upm.git synced 2025-03-15 04:57:30 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Replace strncpy with memcpy

Browse Source 
gcc8 detects that strncpy is overwiritng the null terminating character
the source strings are already initialized to 0 so memcpy would do the same
job

Fixes
rn2903.c:153:5: error: 'strncpy' output may be truncated copying 16 bytes from a string of length 511 [-Werror=stringop-truncation]
     strncpy(dev->hardware_eui, dev->resp_data, RN2903_MAX_HEX_EUI64);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Khem Raj <raj.khem@gmail.com>

%% original patch: 0001-Replace-strncpy-with-memcpy.patch
This commit is contained in:
Khem Raj 2018-05-07 19:53:33 -07:00 committed by OpenEmbedded
parent dc45cd7859
commit d143e5d8b5
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/ecezo/ecezo.c
View File

@ -488,7 +488,7 @@ int ecezo_send_command(const ecezo_context dev, char *cmd, char *buffer,
// our write buffer // our write buffer
char writeBuffer[ECEZO_MAX_BUFFER_LEN]; char writeBuffer[ECEZO_MAX_BUFFER_LEN];
strncpy(writeBuffer, cmd, ECEZO_MAX_BUFFER_LEN); memcpy(writeBuffer, cmd, ECEZO_MAX_BUFFER_LEN-1);
writeBuffer[ECEZO_MAX_BUFFER_LEN - 1] = 0; writeBuffer[ECEZO_MAX_BUFFER_LEN - 1] = 0;
int writelen = strlen(writeBuffer); int writelen = strlen(writeBuffer);

2
src/rn2903/rn2903.c
View File

@ -150,7 +150,7 @@ static rn2903_context _rn2903_postinit(rn2903_context dev,
rn2903_close(dev); rn2903_close(dev);
return NULL; return NULL;
} }
strncpy(dev->hardware_eui, dev->resp_data, RN2903_MAX_HEX_EUI64); memcpy(dev->hardware_eui, dev->resp_data, RN2903_MAX_HEX_EUI64);
return dev; return dev;
} }