alexey.zholtikov/upm
1
0
Fork 0
mirror of https://github.com/eclipse/upm.git synced 2025-03-15 04:57:30 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

bh17xx: use snprintf over sprintf

Browse Source 
Fixes potential unsafe usage of sprintf

Signed-off-by: Mihai Tudor Panu <mihai.tudor.panu@intel.com>
This commit is contained in:
Mihai Tudor Panu 2018-10-11 14:53:42 -07:00
parent 1ddf969020
commit eb8d64f52b
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/bh1749/bh1749.c
View File

@ -686,17 +686,17 @@ upm_result_t bh1749_registers_dump(bh1749_context dev, char *dump)
if(bh1749_read_registers(dev, BH1749_SYSTEM_CONTROL, reg_values, len) != UPM_SUCCESS) if(bh1749_read_registers(dev, BH1749_SYSTEM_CONTROL, reg_values, len) != UPM_SUCCESS)
return UPM_ERROR_OPERATION_FAILED; return UPM_ERROR_OPERATION_FAILED;
count += sprintf(dump, "0x40 "); count += snprintf(dump, 6, "0x40 ");
for(int i = 0; i < len; i++) for(int i = 0; i < len; i++)
count += sprintf(dump + count, "%02X ", reg_values[i]); count += snprintf(dump + count, 4, "%02X ", reg_values[i]);
sprintf(dump + count - 1, "\n"); snprintf(dump + count - 1, 3, "\n");
len = 6; len = 6;
if(bh1749_read_registers(dev, BH1749_INTERRUPT, reg_values, len) != UPM_SUCCESS) if(bh1749_read_registers(dev, BH1749_INTERRUPT, reg_values, len) != UPM_SUCCESS)
return UPM_ERROR_OPERATION_FAILED; return UPM_ERROR_OPERATION_FAILED;
count += sprintf(dump + count, "0x60 "); count += snprintf(dump + count, 6, "0x60 ");
for(int i = 0; i < len; i++) for(int i = 0; i < len; i++)
count += sprintf(dump + count, "%02X ", reg_values[i]); count += snprintf(dump + count, 4, "%02X ", reg_values[i]);
return UPM_SUCCESS; return UPM_SUCCESS;
} }

10
src/bh1792/bh1792.c
View File

@ -873,17 +873,17 @@ upm_result_t bh1792_registers_dump(bh1792_context dev, char *dump)
if(bh1792_read_registers(dev, BH1792_MEAS_CONTROL1, reg_values, len) != UPM_SUCCESS) if(bh1792_read_registers(dev, BH1792_MEAS_CONTROL1, reg_values, len) != UPM_SUCCESS)
return UPM_ERROR_OPERATION_FAILED; return UPM_ERROR_OPERATION_FAILED;
count += sprintf(dump, "0x41 "); count += snprintf(dump, 6, "0x41 ");
for(int i = 0; i < len; i++) for(int i = 0; i < len; i++)
count += sprintf(dump + count, "%02X ", reg_values[i]); count += snprintf(dump + count, 4, "%02X ", reg_values[i]);
sprintf(dump + count - 1, "\n"); snprintf(dump + count - 1, 3, "\n");
len = 1; len = 1;
if(bh1792_read_registers(dev, BH1792_FIFO_LEV, reg_values, len) != UPM_SUCCESS) if(bh1792_read_registers(dev, BH1792_FIFO_LEV, reg_values, len) != UPM_SUCCESS)
return UPM_ERROR_OPERATION_FAILED; return UPM_ERROR_OPERATION_FAILED;
count += sprintf(dump + count, "0x4B "); count += snprintf(dump + count, 6, "0x4B ");
for(int i = 0; i < len; i++) for(int i = 0; i < len; i++)
count += sprintf(dump + count, "%02X ", reg_values[i]); count += snprintf(dump + count, 4, "%02X ", reg_values[i]);
return UPM_SUCCESS; return UPM_SUCCESS;
} }