alexey.zholtikov/upm
1
0
Fork 0
mirror of https://github.com/eclipse/upm.git synced 2025-07-01 17:31:13 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

C: Fixes for sign compares in C libraries

Browse Source 
Added explicit error for sign compares to CMake.  Updated a handful of C
source which compared unsigned vs signed.

Signed-off-by: Noel Eck <noel.eck@intel.com>
This commit is contained in:
Noel Eck
2018-02-07 12:17:54 -08:00
parent 460fdc2eb5
commit fe7bd75c91
14 changed files with 21 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/ds18b20/ds18b20.c
View File

@ -143,8 +143,7 @@ ds18b20_context ds18b20_init(unsigned int uart)
}
// iterate through the found devices and query their resolutions
int i;
for (i=0; i<dev->numDevices; i++)
for (unsigned int i=0; i<dev->numDevices; i++)
{
// read only the first 5 bytes of the scratchpad
static const int numScratch = 5;
@ -191,7 +190,7 @@ void ds18b20_update(const ds18b20_context dev, int index)
{
assert(dev != NULL);
if (index >= dev->numDevices)
if (index >= (int)dev->numDevices)
{
printf("%s: device index %d out of range\n", __FUNCTION__, index);
return;
@ -206,9 +205,7 @@ void ds18b20_update(const ds18b20_context dev, int index)
// convert command to all of them, then wait. This will be
// faster, timey-wimey wise, then converting, sleeping, and
// reading each individual sensor.
int i;
for (i=0; i<dev->numDevices; i++)
for (unsigned int i=0; i<dev->numDevices; i++)
mraa_uart_ow_command(dev->ow, DS18B20_CMD_CONVERT, dev->devices[i].id);
}
else
@ -219,8 +216,7 @@ void ds18b20_update(const ds18b20_context dev, int index)
if (doAll)
{
int i;
for (i=0; i<dev->numDevices; i++)
for (unsigned int i=0; i<dev->numDevices; i++)
dev->devices[i].temperature = readSingleTemp(dev, i);
}
else

2
src/ds18b20/ds18b20.h
View File

@ -53,7 +53,7 @@ extern "C" {
mraa_uart_ow_context ow;
// number of devices found
int numDevices;
unsigned int numDevices;
// list of allocated ds18b20_info_t instances
ds18b20_info_t *devices;