alexey.zholtikov/upm
1
0
Fork 0
mirror of https://github.com/eclipse/upm.git synced 2025-07-15 08:11:12 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

C: Fixes for sign compares in C libraries

Browse Source 
Added explicit error for sign compares to CMake.  Updated a handful of C
source which compared unsigned vs signed.

Signed-off-by: Noel Eck <noel.eck@intel.com>
This commit is contained in:
Noel Eck
2018-02-07 12:17:54 -08:00
parent 460fdc2eb5
commit fe7bd75c91
14 changed files with 21 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/rn2903/rn2903.c
View File

@ -347,14 +347,14 @@ RN2903_RESPONSE_T rn2903_waitfor_response(const rn2903_context dev,
dev->resp_len++;
}
} while ( (elapsed = upm_elapsed_ms(&clock)) < wait_ms);
} while ( (int)(elapsed = upm_elapsed_ms(&clock)) < wait_ms);
if (dev->debug)
printf("\tRESP (%d): '%s'\n", (int)dev->resp_len,
(dev->resp_len) ? dev->resp_data : "");
// check for and return obvious errors
if (elapsed >= wait_ms)
if ((int)elapsed >= wait_ms)
return RN2903_RESPONSE_TIMEOUT;
else if (rn2903_find(dev, RN2903_PHRASE_INV_PARAM))
return RN2903_RESPONSE_INVALID_PARAM;