wip:

README.md

@@ -41,15 +41,15 @@ int main(void)
     zh_avr_ac_dimmer_start();
     for (;;)
     {
-        for (uint8_t i = 1; i <= 100; ++i)
+        for (uint8_t i = 0; i <= 100; ++i)
         {
             zh_avr_ac_dimmer_set(i);
-            _delay_ms(50);
+            _delay_ms(100);
         }
-        for (uint8_t i = 100; i >= 1; --i)
+        for (uint8_t i = 100; i >= 0; --i)
         {
             zh_avr_ac_dimmer_set(i);
-            _delay_ms(50);
+            _delay_ms(100);
         }
     }
     return 0;

include/zh_avr_ac_dimmer.h

@@ -7,8 +7,6 @@
 #include "avr/interrupt.h"
 #include "util/delay.h"
 
-#define ZH_TRIAC_TIME 2 // Triac turn-on time (in microseconds). Depends on the type of triac. Tested on BTA16-600.
-
 #define ZH_AVR_AC_DIMMER_INIT_CONFIG_DEFAULT() \
     {                                          \
         .ac_dimmer_frequency = ZH_50HZ,        \
@@ -43,7 +41,7 @@ extern "C"
      *
      * @param[in] config Pointer to AC dimmer initialized configuration structure. Can point to a temporary variable.
      *
-     * @note Before initialize the AC dimmer recommend initialize zh_avr_ac_dimmer_init_config_t structure with default values.
+     * @note Before initialize the expander recommend initialize zh_avr_ac_dimmer_init_config_t structure with default values.
      *
      * @code zh_avr_ac_dimmer_init_config_t config = ZH_AVR_AC_DIMMER_INIT_CONFIG_DEFAULT @endcode
      *

version.txt

@@ -1 +0,0 @@
-1.0.2

zh_avr_ac_dimmer.c

@@ -5,6 +5,7 @@ volatile static bool _is_dimmer_work = false;
 volatile static uint8_t _dimmer_value = 0;
 volatile static uint8_t _dimmer_count = 0;
 static bool _is_initialized = false;
+static uint8_t _prescaler = 0;
 
 static avr_err_t _zh_avr_ac_dimmer_validate_config(const zh_avr_ac_dimmer_init_config_t *config);
 static void _zh_avr_ac_dimmer_gpio_init(void);
@@ -41,7 +42,7 @@ avr_err_t zh_avr_ac_dimmer_stop(void)
 
 avr_err_t zh_avr_ac_dimmer_set(uint8_t value)
 {
-    ZH_ERROR_CHECK(value <= 100, AVR_ERR_INVALID_ARG);
+    ZH_ERROR_CHECK(_dimmer_value <= 100, AVR_ERR_INVALID_ARG);
     _dimmer_value = value;
     return AVR_OK;
 }
@@ -52,19 +53,19 @@ void zh_avr_ac_dimmer_isr_handler(void)
     switch (_init_config.zero_cross_port)
     {
     case AVR_PORTB:
-        if ((PINB & _init_config.zero_cross_gpio) == _init_config.zero_cross_gpio)
+        if ((PINB & (1 << _init_config.zero_cross_gpio)) == 0)
         {
             flag = true;
         }
         break;
     case AVR_PORTC:
-        if ((PINC & _init_config.zero_cross_gpio) == _init_config.zero_cross_gpio)
+        if ((PINC & (1 << _init_config.zero_cross_gpio)) == 0)
         {
             flag = true;
         }
         break;
     case AVR_PORTD:
-        if ((PIND & _init_config.zero_cross_gpio) == _init_config.zero_cross_gpio)
+        if ((PIND & (1 << _init_config.zero_cross_gpio)) == 0)
         {
             flag = true;
         }
@@ -76,23 +77,22 @@ void zh_avr_ac_dimmer_isr_handler(void)
     {
         if (_dimmer_value != 0)
         {
-            if (_dimmer_value >= 100)
+            if (_dimmer_value == 100)
             {
-                TIMSK0 &= ~(1 << OCIE0A);
                 switch (_init_config.triac_port)
                 {
                 case AVR_PORTB:
                     PORTB |= (1 << _init_config.triac_gpio);
-                    _delay_us(ZH_TRIAC_TIME);
+                    _delay_us(5);
                     PORTB &= ~(1 << _init_config.triac_gpio);
                     break;
                 case AVR_PORTC:
                     PORTC |= (1 << _init_config.triac_gpio);
-                    _delay_us(ZH_TRIAC_TIME);
+                    _delay_us(5);
                     PORTC &= ~(1 << _init_config.triac_gpio);
                 case AVR_PORTD:
                     PORTD |= (1 << _init_config.triac_gpio);
-                    _delay_us(ZH_TRIAC_TIME);
+                    _delay_us(5);
                     PORTD &= ~(1 << _init_config.triac_gpio);
                     break;
                 default:
@@ -102,7 +102,7 @@ void zh_avr_ac_dimmer_isr_handler(void)
             else
             {
                 TCNT0 = 0;
-                TIFR0 = (1 << OCF0A);
+                TCCR0B |= _prescaler;
                 TIMSK0 |= (1 << OCIE0A);
             }
         }
@@ -174,15 +174,15 @@ static avr_err_t _zh_avr_ac_dimmer_timer_init(void)
         {
         case ZH_50HZ:
             OCR0A = 99;
-            TCCR0B |= (1 << CS01);
+            _prescaler = (1 << CS01);
             break;
         case ZH_60HZ:
             OCR0A = 82;
-            TCCR0B |= (1 << CS01);
+            _prescaler = (1 << CS01);
             break;
         case ZH_400HZ:
             OCR0A = 99;
-            TCCR0B |= (1 << CS00);
+            _prescaler = (1 << CS00);
             break;
         default:
             break;
@@ -193,15 +193,15 @@ static avr_err_t _zh_avr_ac_dimmer_timer_init(void)
         {
         case ZH_50HZ:
             OCR0A = 24;
-            TCCR0B |= (1 << CS01) | (1 << CS00);
+            _prescaler = (1 << CS01) | (1 << CS00);
             break;
         case ZH_60HZ:
             OCR0A = 165;
-            TCCR0B |= (1 << CS01);
+            _prescaler = (1 << CS01);
             break;
         case ZH_400HZ:
             OCR0A = 24;
-            TCCR0B |= (1 << CS01);
+            _prescaler = (1 << CS01);
             break;
         default:
             break;
@@ -212,15 +212,15 @@ static avr_err_t _zh_avr_ac_dimmer_timer_init(void)
         {
         case ZH_50HZ:
             OCR0A = 249;
-            TCCR0B |= (1 << CS01);
+            _prescaler = (1 << CS01);
             break;
         case ZH_60HZ:
             OCR0A = 207;
-            TCCR0B |= (1 << CS01);
+            _prescaler = (1 << CS01);
             break;
         case ZH_400HZ:
             OCR0A = 249;
-            TCCR0B |= (1 << CS00);
+            _prescaler = (1 << CS00);
             break;
         default:
             break;
@@ -235,29 +235,30 @@ static avr_err_t _zh_avr_ac_dimmer_timer_init(void)
 
 ISR(TIMER0_COMPA_vect)
 {
-    if (_dimmer_count >= (100 - _dimmer_value))
+    ++_dimmer_count;
+    if (_dimmer_count == (100 - _dimmer_value))
     {
         _dimmer_count = 0;
-        TIMSK0 &= ~(1 << OCIE0A);
+        TCCR0B = 0;
+        TIMSK0 = 0;
         switch (_init_config.triac_port)
         {
         case AVR_PORTB:
             PORTB |= (1 << _init_config.triac_gpio);
-            _delay_us(ZH_TRIAC_TIME);
+            _delay_us(5);
             PORTB &= ~(1 << _init_config.triac_gpio);
             break;
         case AVR_PORTC:
             PORTC |= (1 << _init_config.triac_gpio);
-            _delay_us(ZH_TRIAC_TIME);
+            _delay_us(5);
             PORTC &= ~(1 << _init_config.triac_gpio);
         case AVR_PORTD:
             PORTD |= (1 << _init_config.triac_gpio);
-            _delay_us(ZH_TRIAC_TIME);
+            _delay_us(5);
             PORTD &= ~(1 << _init_config.triac_gpio);
             break;
         default:
             break;
         }
     }
-    ++_dimmer_count;
 }