alexey.zholtikov/upm
1
0
Fork 0
mirror of https://github.com/eclipse/upm.git synced 2025-03-15 04:57:30 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

pca9685: fix problem where setting pwm accidentally cleared full bits

Browse Source 
When setting the On or Off times, the FullOn or FullOff control bits
would be improperly masked and therefore not preserved.

Signed-off-by: Jon Trulson <jtrulson@ics.com>
Signed-off-by: Sisinty Sasmita Patra<sisinty.s.patra@intel.com>
This commit is contained in:
Jon Trulson 2015-08-18 17:45:10 -06:00 committed by sisinty sasmita patra
parent 488ea234d5
commit 4a6492af0a
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/pca9685/pca9685.cxx
View File

@ -182,9 +182,9 @@ bool PCA9685::ledFullOn(uint8_t led, bool val)
uint8_t bits = readByte(regoff);
if (val)
bits |= ((1 << 4) & 0xff);
bits |= 0x10;
else
bits &= ~((1 << 4) & 0xff);
bits &= ~0x10;
return writeByte(regoff, bits);
}
@ -209,9 +209,9 @@ bool PCA9685::ledFullOff(uint8_t led, bool val)
uint8_t bits = readByte(regoff);
if (val)
bits |= ((1 << 4) & 0xff);
bits |= 0x10;
else
bits &= ~((1 << 4) & 0xff);
bits &= ~0x10;
return writeByte(regoff, bits);
}
@ -240,7 +240,7 @@ bool PCA9685::ledOnTime(uint8_t led, uint16_t time)
regoff = REG_LED0_ON_L + (led * 4);
// we need to preserve the full ON bit in *_ON_H
uint8_t onbit = (readByte(regoff + 1) & 0x40);
uint8_t onbit = (readByte(regoff + 1) & 0x10);
time = (time & 0x0fff) | (onbit << 8);
@ -271,7 +271,7 @@ bool PCA9685::ledOffTime(uint8_t led, uint16_t time)
regoff = REG_LED0_ON_L + (led * 4) + 2;
// we need to preserve the full OFF bit in *_OFF_H
uint8_t offbit = (readByte(regoff + 1) & 0x40);
uint8_t offbit = (readByte(regoff + 1) & 0x10);
time = (time & 0x0fff) | (offbit << 8);